Skip to content

src: include uv.h in node_binding header #31265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codebytere wants to merge 1 commit into from
Closed

src: include uv.h in node_binding header #31265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: include uv.h in node_binding header 
This was removed in 3bb085d
but is needed by Electron on Windows, as otherwise compilation errors
will occur as a result of unknown libuv types.
  • Loading branch information
@codebytere
codebytere committed Jan 8, 2020
commit 4d8ffe2e2c74d39118636d938e6d28f85290df2e
1 change: 1 addition & 0 deletions src/node_binding.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "node.h"
#define NAPI_EXPERIMENTAL
#include "node_api.h"
#include "uv.h"

enum {
NM_F_BUILTIN = 1 << 0, // Unused.
Expand Down