Skip to content

[v10.x] Backport large pages to v10.x #31105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrielschulhof wants to merge 18 commits into from
Closed

[v10.x] Backport large pages to v10.x #31105

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6b9dd7b
src: large pages option: FreeBSD support proposal
devnexen Jun 20, 2019
6d93a8a
src: readlink("/proc/self/exe") -> uv_exename()
bnoordhuis Jun 21, 2019
bbaa065
src: large pages fix FreeBSD fix region size
devnexen Jul 17, 2019
86419d8
build: enable linux large pages LLVM lld linkage support
devnexen Aug 2, 2019
01de6c2
src: add large page support for macOS
devnexen Aug 5, 2019
2b373bd
src: fix largepages regression
Oct 9, 2019
d5b5b22
src: refine maps parsing for large pages
Oct 9, 2019
b4d01ba
src: make --use-largepages a runtime option
Dec 13, 2019
7502e31
build: re-introduce --use-largepages as no-op
Dec 24, 2019
ed5e50d
build: switch realpath to pwd
Dec 26, 2019
7075e9d
src: make large_pages node.cc include conditional
lundibundi Dec 24, 2019
88b76d1
build: warn upon --use-largepages config option
Dec 26, 2019
75947e1
src: clean up large_pages code
lundibundi Jan 5, 2020
2693510
src: reduce large pages code duplication
Jan 16, 2020
56305ee
src: use __executable_start for linux hugepages
bnoordhuis Jan 28, 2020
8a7f607
src: include large pages source unconditionally
Feb 21, 2020
f3643bf
src: start the .text section with an asm symbol
Feb 27, 2020
c71d059
build: fix building with ninja
richardlau Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: reduce large pages code duplication 
Declaring and initializing a `struct text_region` is common to all
three implementations of the large pages mapping code. Let's make it
unconditional.

PR-URL: #31385
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: JungMinu - Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
  • Loading branch information
Gabriel Schulhof committed Mar 6, 2020
commit 269351021e9759d2065e5134fb54be7250b33584
10 changes: 2 additions & 8 deletions src/large_pages/node_large_page.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,15 @@ inline uintptr_t hugepage_align_down(uintptr_t addr) {
// This is also handling the case where the first line is not the binary.

static struct text_region FindNodeTextRegion() {
struct text_region nregion;
nregion.found_text_region = false;
#if defined(__linux__)
std::ifstream ifs;
std::string map_line;
std::string permission;
std::string dev;
char dash;
uintptr_t start, end, offset, inode;
struct text_region nregion;

nregion.found_text_region = false;

ifs.open("/proc/self/maps");
if (!ifs) {
Expand Down Expand Up @@ -169,9 +168,6 @@ static struct text_region FindNodeTextRegion() {

ifs.close();
#elif defined(__FreeBSD__)
struct text_region nregion;
nregion.found_text_region = false;

std::string exename;
{
char selfexe[PATH_MAX];
Expand Down Expand Up @@ -228,8 +224,6 @@ static struct text_region FindNodeTextRegion() {
start += cursz;
}
#elif defined(__APPLE__)
struct text_region nregion;
nregion.found_text_region = false;
struct vm_region_submap_info_64 map;
mach_msg_type_number_t count = VM_REGION_SUBMAP_INFO_COUNT_64;
vm_address_t addr = 0UL;
Expand Down