fixup! benchmark: add benchmark on async_hooks enabled http server

nodejs · legendecas · Dec 26, 2019 · Jan 1, 2020 · Jan 2, 2020 · Jan 1, 2020
commit 75a1603755c07de3de533bd55153812fd1f558ee
diff --git a/benchmark/async_hooks/http-server.js b/benchmark/async_hooks/http-server.js
@@ -2,20 +2,26 @@
 const common = require('../common.js');
 
 const bench = common.createBenchmark(main, {
-  asyncHooks: ['enabed', 'disabled', 'none'],
-  c: [50, 500]
+  asyncHooks: ['init', 'before', 'after', 'all', 'disabled', 'none'],
+  connections: [50, 500]
 });
 
-function main({ asyncHooks, c }) {
+function main({ asyncHooks, connections }) {
   if (asyncHooks !== 'none') {
-    const hook = require('async_hooks').createHook({
+    let hooks = {
       init() {},
       before() {},
       after() {},
       destroy() {},
       promiseResolve() {}
-    });
-    if (asyncHooks === 'enabed') {
+    };
+    if (asyncHooks !== 'all' || asyncHooks !== 'disabled') {
+      hooks = {
+        [asyncHooks]: () => {}
+      };
+    }
+    const hook = require('async_hooks').createHook(hooks);
+    if (asyncHooks !== 'disabled') {
       hook.enable();
     }
   }
@@ -25,8 +31,8 @@ function main({ asyncHooks, c }) {
     const path = '/buffer/4/4/normal/1';
 
     bench.http({
-      path: path,
-      connections: c
+      connections,
+      path,
     }, () => {
       server.close();
     });

diff --git a/test/benchmark/test-benchmark-async-hooks.js b/test/benchmark/test-benchmark-async-hooks.js
@@ -14,7 +14,7 @@ runBenchmark('async_hooks',
              [
                'method=trackingDisabled',
                'n=10',
-               'asyncHooks=enabled',
-               'c=50'
+               'asyncHooks=all',
+               'connections=50'
              ],
              {});