Skip to content

esm: implement import.meta.resolve and make nodejs: scheme public #31032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 2 commits into from
Closed

esm: implement import.meta.resolve and make nodejs: scheme public #31032

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9db74ae
esm: import.meta.resolve with nodejs: builtins
guybedford Dec 19, 2019
714620e
windows fixup
guybedford Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
windows fixup
  • Loading branch information
@guybedford
guybedford committed Feb 3, 2020
commit 714620e1e11f64ae2159dbdb5168724c1c61e4a1
3 changes: 2 additions & 1 deletion lib/internal/modules/esm/resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const internalFS = require('internal/fs/utils');
const { NativeModule } = require('internal/bootstrap/loaders');
const { realpathSync } = require('fs');
const { getOptionValue } = require('internal/options');
const { sep } = require('path');

const preserveSymlinks = getOptionValue('--preserve-symlinks');
const preserveSymlinksMain = getOptionValue('--preserve-symlinks-main');
Expand Down Expand Up @@ -65,7 +66,7 @@ function defaultResolve(specifier, { parentURL } = {}, defaultResolve) {
[internalFS.realpathCacheKey]: realpathCache
});
const old = url;
url = pathToFileURL(real + (urlPath.endsWith('/') ? '/' : ''));
url = pathToFileURL(real + (urlPath.endsWith(sep) ? '/' : ''));
url.search = old.search;
url.hash = old.hash;
}
Expand Down