Skip to content

module: self resolve bug fixes and esm ordering #31009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 5 commits into from
Closed

module: self resolve bug fixes and esm ordering #31009

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
839b837
module: self resolve bug fix and esm ordering
guybedford Dec 17, 2019
b3889b8
remove unused index reference and logging
guybedford Dec 17, 2019
8cca5c9
strict self resolution opt-in
guybedford Dec 19, 2019
ff11612
always encapsulate on exports
guybedford Dec 19, 2019
1ddbc0e
fixup remaining doc lines
guybedford Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused index reference and logging
  • Loading branch information
@guybedford
guybedford authored Dec 17, 2019
commit b3889b8a00d979110adef25e08f6f36758cd9602
3 changes: 1 addition & 2 deletions test/es-module/test-esm-exports.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ function assertIncludes(actual, expected) {
'/node_modules/pkgexports/resolve-self.js',
'Package name self resolution',
],
].forEach(([flag, file, message], index) => {
].forEach(([flag, file, message]) => {
const child = spawn(process.execPath, [flag, path(file)]);

let stderr = '';
Expand All @@ -185,7 +185,6 @@ function assertIncludes(actual, expected) {
stderr += data;
});
child.on('close', (code, signal) => {
console.log(stderr.toString());
strictEqual(code, 0);
strictEqual(signal, null);
ok(stderr.toString().includes(
Expand Down