Skip to content

doc: add note about fs.close undefined behavior #30966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 6 commits into from
Closed

doc: add note about fs.close undefined behavior #30966

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a284117
doc: add note about fs.close undefined behavior
ronag Dec 14, 2019
fe0142f
fixup: any fs op
ronag Dec 14, 2019
bc751b3
Update doc/api/fs.md
ronag Dec 15, 2019
6fa8257
Update doc/api/fs.md
ronag Dec 15, 2019
cc53609
fixup: add note to closeSync as well
ronag Dec 15, 2019
c66cce8
Apply suggestions from code review
ronag Dec 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: add note about fs.close undefined behavior
  • Loading branch information
@ronag
ronag committed Dec 14, 2019
commit a284117394c8cf847e13649ec2a187bedd150f13
3 changes: 3 additions & 0 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1533,6 +1533,9 @@ changes:
Asynchronous close(2). No arguments other than a possible exception are given
to the completion callback.

Calling `fs.close` on any file descriptor (`fd`) that is currently in use
Comment thread
ronag marked this conversation as resolved.
Outdated
through `fs.read`, `fs.write` or `fs.writev` may lead to undefined behavior.
Comment thread
ronag marked this conversation as resolved.
Outdated

## fs.closeSync(fd)
<!-- YAML
added: v0.1.21
Expand Down