Skip to content

process: fix promise catching #30957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pd4d10 wants to merge 1 commit into from
Closed

process: fix promise catching #30957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
process: fix promise catching 
Fixes: #30953
  • Loading branch information
@pd4d10
pd4d10 committed Dec 14, 2019
commit f313e8bd6165d36c5f24fcdf676581ef2dbe050f
3 changes: 2 additions & 1 deletion lib/internal/process/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ function handledRejection(promise) {
return;
}
}
setHasRejectionToWarn(false);
if (maybeUnhandledPromises.size === 0 && asyncHandledRejections.length === 0)
setHasRejectionToWarn(false);
}

const unhandledRejectionErrName = 'UnhandledPromiseRejectionWarning';
Expand Down
12 changes: 12 additions & 0 deletions test/parallel/test-promises-unhandled-rejections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,3 +718,15 @@ asyncTest(
let timer = setTimeout(common.mustNotCall(), 10000);
},
);

// https://github.com/nodejs/node/issues/30953
asyncTest(
'Catching a promise should not take effect on previous promises',
function(done) {
onUnhandledSucceed(done, function(reason, promise) {
assert.strictEqual(reason, '1');
});
Promise.reject('1');
Promise.reject('2').catch(function() {});
}
);