Skip to content

src: make --use-largepages a runtime option #30954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrielschulhof wants to merge 10 commits into from
Closed

src: make --use-largepages a runtime option #30954

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a83c5df
src: make --use-largepages a runtime option
Dec 13, 2019
65622bf
src: make --use-largepages a three-valued option
Dec 15, 2019
6e0fd1c
update test
Dec 15, 2019
a93064d
heed review comments
Dec 17, 2019
764c109
convert values to strings
Dec 17, 2019
67bc994
only add sources if arch is x64
Dec 17, 2019
cc54363
update test comment
Dec 17, 2019
52d025b
rename "silent" to "on"
Dec 17, 2019
764f45e
make "on" verbose, and retain "silent"
Dec 17, 2019
c504237
fix FreeBSD
Dec 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test
  • Loading branch information
Gabriel Schulhof committed Dec 15, 2019
commit 6e0fd1c7a9a25edca9bd3f03a2d6b3f480010e29
28 changes: 20 additions & 8 deletions test/parallel/test-startup-large-pages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,25 @@ require('../common');
const assert = require('assert');
const { spawnSync } = require('child_process');

const child = spawnSync(process.execPath, [ '--use-largepages', '-p', '42' ]);
const stdout = child.stdout.toString().match(/\S+/g);
{
const child = spawnSync(process.execPath,
[ '--use-largepages=1', '-p', '42' ]);
const stdout = child.stdout.toString().match(/\S+/g);
assert.strictEqual(child.status, 0);
assert.strictEqual(child.signal, null);
assert.strictEqual(stdout.length, 1);
assert.strictEqual(stdout[0], '42');
}

assert.strictEqual(child.status, 0);
assert.strictEqual(child.signal, null);
assert.strictEqual(stdout.length, 1);
assert.strictEqual(stdout[0], '42');
{
const child = spawnSync(process.execPath,
[ '--use-largepages=3', '-p', '42' ]);
assert.strictEqual(child.status, 9);
assert.strictEqual(child.signal, null);
assert.strictEqual(child.stderr.toString().match(/\S+/g).slice(1).join(' '),
'--use-largepages must be one of 0, 1, or 2');
}

// TODO(gabrielschulhof): Make assertions about the stderr, which may or may not
// contain a message indicating that mapping to large pages has failed.
// TODO(gabrielschulhof): Run with --use-largepages=2 and make assertions about
Comment thread
gabrielschulhof marked this conversation as resolved.
Outdated
// the stderr, which may or may not contain a message indicating that mapping to
// large pages has failed.