Skip to content

lib: change var to let/const #30910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
herrmannplatz wants to merge 1 commit into from
Closed

lib: change var to let/const #30910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: change var to let/const
  • Loading branch information
rene.herrmann committed Dec 12, 2019
commit 93f02060ad1eb8b0a96d38e46a9f4dbfd6a4ab97
5 changes: 2 additions & 3 deletions lib/internal/console/constructor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,11 @@ function Console(options /* or: stdout, stderr, ignoreErrors = true */) {

// Bind the prototype functions to this Console instance
const keys = ObjectKeys(Console.prototype);
for (var v = 0; v < keys.length; v++) {
var k = keys[v];
for (const key of keys) {
// We have to bind the methods grabbed from the instance instead of from
// the prototype so that users extending the Console can override them
// from the prototype chain of the subclass.
this[k] = this[k].bind(this);
this[key] = this[key].bind(this);
}

this[kBindStreamsEager](stdout, stderr);
Expand Down