Skip to content

repl: add completion preview #30907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 12 commits into from
Closed

repl: add completion preview #30907

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
19dac98
repl: remove dead code
BridgeAR Dec 10, 2019
c65f3f1
repl: simplify repl autocompletion
BridgeAR Dec 10, 2019
ec47482
repl: simplify code
BridgeAR Dec 10, 2019
43ae689
readline: update ansi-regex
BridgeAR Dec 11, 2019
1426e6c
repl,readline: refactor common code
BridgeAR Dec 11, 2019
42d3590
repl,readline: refactor for simplicity
BridgeAR Dec 11, 2019
ca14259
repl: improve completion
BridgeAR Dec 11, 2019
1cbef42
repl: add completion preview
BridgeAR Dec 11, 2019
707cba4
repl: fix preview bug in case of long lines
BridgeAR Dec 11, 2019
ca4c894
test: add multiple repl preview tests
BridgeAR Dec 13, 2019
0cd4153
fixup: repl: add completion preview
BridgeAR Dec 14, 2019
2138fd7
fixup: test: add multiple repl preview tests
BridgeAR Dec 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
repl: fix preview bug in case of long lines 
This addresses an issue that is caused by lines that exceed the
current window columns. That would cause the preview to confuse the
REPL. This is meant as hot fix. The preview should be able to handle
these cases appropriately as well later on.
  • Loading branch information
@BridgeAR
BridgeAR committed Dec 14, 2019
commit 707cba4493ddafa16723e33cf139eb934680a1a3
10 changes: 10 additions & 0 deletions lib/internal/repl/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,16 @@ function setupPreview(repl, contextSymbol, bufferSymbol, active) {
return;
}

// Do not show previews in case the current line is longer than the column
// width.
// TODO(BridgeAR): Fix me. This should not be necessary. It currently breaks
// the output though. We also have to check for characters that have more
// than a single byte as length. Check Interface.prototype._moveCursor. It
// contains the necessary logic.
if (repl.line.length + repl._prompt.length > repl.columns) {
return;
}

// Add the autocompletion preview.
// TODO(BridgeAR): Trigger the input preview after the completion preview.
// That way it's possible to trigger the input prefix including the
Expand Down