Skip to content

http: certain response headers do not allow multiple instances #3090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 5 commits into from
Closed

http: certain response headers do not allow multiple instances #3090

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3827ad5
http: add callback is function check
jasnell Sep 27, 2015
4eed242
http: do not allow multiple instances of certain response headers
jasnell Sep 27, 2015
5333b54
test: cleanup nits in test-http-response-multiheaders.js
jasnell Sep 27, 2015
65047e0
http: if callback is truthy but not a function, throw
jasnell Oct 6, 2015
4652af7
test: expand test-http-response-multiheaders test
jasnell Oct 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: expand test-http-response-multiheaders test 
Include writeHead in the test per @bnoordhuis' suggestion
  • Loading branch information
@jasnell
jasnell committed Oct 6, 2015
commit 4652af7bb545b4842254348030c60f0d2b0548bc
41 changes: 31 additions & 10 deletions test/parallel/test-http-response-multiheaders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,40 @@ const norepeat = [
];

const server = http.createServer(function(req, res) {
for (let name of norepeat) {
res.setHeader(name, ['A', 'B']);
var num = req.headers['x-num'];
if (num == 1) {
for (let name of norepeat) {
res.setHeader(name, ['A', 'B']);
}
res.setHeader('X-A', ['A', 'B']);
} else if (num == 2) {
let headers = {};
for (let name of norepeat) {
headers[name] = ['A', 'B'];
}
headers['X-A'] = ['A', 'B'];
res.writeHead(200, headers);
}
res.setHeader('X-A', ['A', 'B']);
res.end('ok');
});

server.listen(common.PORT, common.mustCall(function() {
http.get({port:common.PORT}, common.mustCall(function(res) {
server.close();
for (let name of norepeat) {
assert.equal(res.headers[name], 'A');
}
assert.equal(res.headers['x-a'], 'A, B');
}));
for (let n = 1; n <= 2 ; n++) {
// this runs twice, the first time, the server will use
// setHeader, the second time it uses writeHead. The
// result on the client side should be the same in
// either case -- only the first instance of the header
// value should be reported for the header fields listed
// in the norepeat array.
http.get(
{port:common.PORT, headers:{'x-num': n}},
common.mustCall(function(res) {
if (n == 2) server.close();
for (let name of norepeat) {
assert.equal(res.headers[name], 'A');
}
assert.equal(res.headers['x-a'], 'A, B');
})
);
}
}));