Skip to content

[WIP] Support requiring .mjs files #30891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weswigham wants to merge 5 commits into from
Closed

[WIP] Support requiring .mjs files #30891

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
219964b
module: support requiring .mjs files
weswigham Dec 10, 2019
286692b
Fix lints
weswigham Dec 10, 2019
fe74e6f
Remove unneeded call to `promiseWait` - we only need this once TLA su…
weswigham Dec 10, 2019
afe50b9
Fix mjs test
weswigham Dec 10, 2019
0a1faa4
Fix lints, again
weswigham Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix mjs test
  • Loading branch information
@weswigham
weswigham committed Dec 10, 2019
commit afe50b98fddb1af985a6b36b3f01da756019bf92
8 changes: 1 addition & 7 deletions test/parallel/test-require-mjs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,4 @@
require('../common');
const assert = require('assert');

assert.throws(
() => require('../fixtures/es-modules/test-esm-ok.mjs'),
{
message: /Must use import to load ES Module/,
code: 'ERR_REQUIRE_ESM'
}
);
assert.equal(require('../fixtures/es-modules/test-esm-ok.mjs').default, true);