Skip to content

test: disable colorMode in test-console-group #30886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Dec 12, 2019
Merged

test: disable colorMode in test-console-group #30886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: disable colorMode in test-console-group 
Disable colorMode in test-console-group so that the test will succeed if
run without the test runner from the command line.

PR-URL: #30886
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@Trott
Trott committed Dec 12, 2019
commit 82d477a8385cf1a5e65ba5bc393803daed7a488a
4 changes: 3 additions & 1 deletion test/parallel/test-console-group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ function setup() {
stderr += data;
});

c = new Console(process.stdout, process.stderr);
c = new Console({ stdout: process.stdout,
stderr: process.stderr,
colorMode: false });
}

function teardown() {
Expand Down