Skip to content

src: accept single argument in getProxyDetails #30858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 3 commits into from
Closed

src: accept single argument in getProxyDetails #30858

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
578f0b0
src: accept single argument in getProxyDetails
BridgeAR Dec 8, 2019
e42bfc6
fixup: change comment to TODO
BridgeAR Dec 9, 2019
aa2f0bf
fixup: mention esm explictly
BridgeAR Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: change comment to TODO
  • Loading branch information
@BridgeAR
BridgeAR committed Dec 9, 2019
commit e42bfc63d87d6bed9de3554e66070d6c9c959207
4 changes: 3 additions & 1 deletion src/node_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ static void GetProxyDetails(const FunctionCallbackInfo<Value>& args) {

Local<Proxy> proxy = args[0].As<Proxy>();

// The length check keeps this function backwards compatible.
// TODO(BridgeAR): Remove the length check as soon as we prohibit access to
// the util binding layer. It's accessed in the wild and some code would break
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be more explicit than "some code". We know of esm. Are there other packages (that are popular)?

// in case the check is removed.
if (args.Length() == 1 || args[1]->IsTrue()) {
Copy link
Copy Markdown
Member

@addaleax addaleax Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The length check here doesn’t change behaviour and could safely be dropped, so you can apply the TODO comment right now if you want.

Copy link
Copy Markdown
Member Author

@BridgeAR BridgeAR Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean if I write if (!args[1]->IsFalse()) { ...old behavior... } else { ...new behavior... }?

Copy link
Copy Markdown
Member

@addaleax addaleax Dec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, something like that … feel free to ignore though :)

Local<Value> ret[] = {
proxy->GetTarget(),
Expand Down