Skip to content

Native buf checks #3080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trevnorris wants to merge 2 commits into from
Closed

Native buf checks #3080

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7547947
buffer: cleanup usage of __proto__
trevnorris Sep 26, 2015
b7eb4f1
buffer: Only check if instance is Uint8Array
trevnorris Sep 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
buffer: cleanup usage of __proto__ 
Prefer using Object.setPrototypeOf() instead.
  • Loading branch information
@trevnorris
trevnorris committed Oct 6, 2015
commit 7547947dbf560a4a705b5338f495a1ea5ca8b7db
8 changes: 4 additions & 4 deletions lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ function Buffer(arg) {
return fromObject(arg);
}

Buffer.prototype.__proto__ = Uint8Array.prototype;
Buffer.__proto__ = Uint8Array;
Object.setPrototypeOf(Buffer.prototype, Uint8Array.prototype);
Object.setPrototypeOf(Buffer, Uint8Array);


function SlowBuffer(length) {
Expand All @@ -72,8 +72,8 @@ function SlowBuffer(length) {
return ui8;
}

SlowBuffer.prototype.__proto__ = Buffer.prototype;
SlowBuffer.__proto__ = Buffer;
Object.setPrototypeOf(SlowBuffer.prototype, Uint8Array.prototype);
Object.setPrototypeOf(SlowBuffer, Uint8Array);


function allocate(size) {
Expand Down