Skip to content

module: conditional exports condition renaming proposal for usability #30799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 8 commits into from
Closed

module: conditional exports condition renaming proposal for usability #30799

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d24399c
module: conditional exports usability updates
guybedford Dec 5, 2019
6de8bc8
module: support default condition until conditional exports unflag
guybedford Dec 5, 2019
ff61324
change to use require/import
guybedford Dec 5, 2019
7483163
update condition descriptions
guybedford Dec 9, 2019
1fe09b1
remove resolver references from condition definitions
guybedford Dec 9, 2019
59baa76
maintain "default" in documentation
guybedford Dec 10, 2019
c7fe517
add warning note
guybedford Dec 10, 2019
ecd1017
linting fixes, update other msg
guybedford Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add warning note
  • Loading branch information
@guybedford
guybedford committed Dec 10, 2019
commit c7fe517d6a6ec65ed22bb25f5208325a9d6f532c
4 changes: 4 additions & 0 deletions doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,10 @@ The conditions supported in Node.js are matched in the following order:
4. `"default"` - the generic fallback that will always match if no other
more specific condition is matched first. Can be a CommonJS or ES module
file.

> Setting any of the above flagged conditions for a published package is not
recommended until they are unflagged to avoid breaking changes to packages in
future.

Using the `"require"` condition it is possible to define a package that will
have a different exported value for CommonJS and ES modules, which can be a
Expand Down