Skip to content

test: improve wasi test coverage and simplify tmpdir imports #30770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 2 commits into from
Dec 5, 2019
Merged

test: improve wasi test coverage and simplify tmpdir imports #30770

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc5c3b5
test: simplify tmpdir import in wasi tests
Trott Dec 2, 2019
bcd5491
test: improve wasi test coverage
Trott Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: simplify tmpdir import in wasi tests 
PR-URL: #30770
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
@Trott
Trott committed Dec 5, 2019
commit cc5c3b557ee8f52dcbfa42984f38a80c55e6c3be
2 changes: 1 addition & 1 deletion test/wasi/test-wasi-symlinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ if (process.argv[2] === 'wasi-child') {

const assert = require('assert');
const cp = require('child_process');
const tmpdir = require('../../test/common/tmpdir');
const tmpdir = require('../common/tmpdir');

// Setup the sandbox environment.
tmpdir.refresh();
Expand Down
2 changes: 1 addition & 1 deletion test/wasi/test-wasi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const common = require('../common');

if (process.argv[2] === 'wasi-child') {
const fixtures = require('../common/fixtures');
const tmpdir = require('../../test/common/tmpdir');
const tmpdir = require('../common/tmpdir');
const fs = require('fs');
const path = require('path');

Expand Down