Skip to content

doc: clarify text about using 'session' event for compatibility #30746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
+7 −7
Closed

doc: clarify text about using 'session' event for compatibility #30746

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
881aafa
doc: clarify text about using 'session' event for compatibility
Trott Dec 1, 2019
07b44e2
fixup! doc: clarify text about using 'session' event for compatibility
Trott Dec 3, 2019
c2f51a7
fixup! fixup! doc: clarify text about using 'session' event for compa…
Trott Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! doc: clarify text about using 'session' event for compatibility
  • Loading branch information
@Trott
Trott committed Dec 3, 2019
commit 07b44e2eff1ab072bcc98d83b17f47009d05e51b
2 changes: 1 addition & 1 deletion doc/api/tls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ See [Session Resumption][] for more information.
For TLSv1.3, it is necessary to wait for the 'session' event to get a resumable
session. This is because only ticket-based resumption is allowed by the
protocol. Tickets aren't sent until after the handshake completes. Applications
Comment thread
Trott marked this conversation as resolved.
Outdated
should use the 'session' event instead of [`tls.TLSSocket.getSession()`][] to
should use the `'session'` event instead of [`tls.TLSSocket.getSession()`][] to
ensure they work for all TLS versions. Applications that only expect to get or
use 1 session should listen for this event only once:

Expand Down