Skip to content

[v8.x backport] Windows CI job update changes #30727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaocgreis wants to merge 2 commits into from
Closed

[v8.x backport] Windows CI job update changes #30727

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4145bd3
build,win: add test-ci-native and test-ci-js
joaocgreis Nov 27, 2019
c155914
build,win: propagate error codes in vcbuild
joaocgreis Nov 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build,win: propagate error codes in vcbuild 
Don't exit vcbuild with error code 0 when cctest fails.
  • Loading branch information
@joaocgreis
joaocgreis committed Nov 30, 2019
commit c155914aa77c8149afbd8c1a88b96ff9d0cbf5ee
5 changes: 4 additions & 1 deletion vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ set v8_build_options=
set http2_debug=
set nghttp2_debug=
set link_module=
set exit_code=0

:next-arg
if "%1"=="" goto args-done
Expand Down Expand Up @@ -486,10 +487,12 @@ if defined skip_cctest goto run-test-py
if not exist %config%\cctest.exe goto run-test-py
echo running 'cctest %cctest_args%'
"%config%\cctest" %cctest_args%
if %errorlevel% neq 0 set exit_code=%errorlevel%
:run-test-py
REM when building a static library there's no binary to run tests
if defined enable_static goto test-v8
call :run-python tools\test.py %test_args%
if %errorlevel% neq 0 set exit_code=%errorlevel%

:test-v8
if not defined custom_v8_test goto lint-cpp
Expand Down Expand Up @@ -587,7 +590,7 @@ echo %cmd1%
exit /b %ERRORLEVEL%

:exit
goto :EOF
exit /b %exit_code%


rem ***************
Expand Down