Skip to content

build: fix static dll compilation on Windows #30695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidhouweling wants to merge 3 commits into from
Closed

build: fix static dll compilation on Windows #30695

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
114680f
build: fix missing winmm dependency in libnode
davidhouweling Nov 28, 2019
12c7739
build: fix share mode for windows to output libnode as lib
davidhouweling Nov 28, 2019
474f6e9
build: fix node compile to output correctly in shared mode
davidhouweling Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build: fix node compile to output correctly in shared mode 
When compiling node in shared mode, the output should be a
shared library rather than an executable.

Fixes: #28845
  • Loading branch information
@davidhouweling
davidhouweling committed Feb 4, 2020
commit 474f6e988edd29ba5af114c735df8ab9603b0a7f
3 changes: 2 additions & 1 deletion node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
'node_shared_openssl%': 'false',
'node_v8_options%': '',
'node_core_target_name%': 'node',
'node_target_type%': 'executable',
'node_lib_target_name%': 'libnode',
'node_intermediate_lib_type%': 'static_library',
'node_builtin_modules_path%': '',
Expand Down Expand Up @@ -315,7 +316,7 @@
'targets': [
{
'target_name': '<(node_core_target_name)',
'type': 'executable',
'type': '<(node_target_type)',

'defines': [
'NODE_WANT_INTERNALS=1',
Expand Down