Skip to content

tools: update ESLint to 6.7.1 #30598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjihrig merged 2 commits into from
Nov 25, 2019
Merged

tools: update ESLint to 6.7.1 #30598

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90fb308
tools: update ESLint to 6.7.1
cjihrig Nov 22, 2019
a50cc2e
tools: enable more eslint rules
cjihrig Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tools: enable more eslint rules 
This commit enables these new in ESLint 6.7.0 rules:

- no-constructor-return
- no-dupe-else-if
- no-setter-return

PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
@cjihrig
cjihrig committed Nov 25, 2019
commit a50cc2ed0eecf89713ea11c64b00dee416c88362
3 changes: 3 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,14 @@ module.exports = {
'no-class-assign': 'error',
'no-confusing-arrow': 'error',
'no-const-assign': 'error',
'no-constructor-return': 'error',
'no-control-regex': 'error',
'no-debugger': 'error',
'no-delete-var': 'error',
'no-dupe-args': 'error',
'no-dupe-class-members': 'error',
'no-dupe-keys': 'error',
'no-dupe-else-if': 'error',
'no-duplicate-case': 'error',
'no-duplicate-imports': 'error',
'no-empty-character-class': 'error',
Expand Down Expand Up @@ -247,6 +249,7 @@ module.exports = {
'no-return-await': 'error',
'no-self-assign': 'error',
'no-self-compare': 'error',
'no-setter-return': 'error',
'no-shadow-restricted-names': 'error',
'no-tabs': 'error',
'no-template-curly-in-string': 'error',
Expand Down