Skip to content

stream: invoke buffered write callbacks on error #30596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 6 commits into from
Closed

stream: invoke buffered write callbacks on error #30596

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8263fd1
stream: invoke buffered write callbacks on error
ronag Nov 22, 2019
614ba71
fixup: comment + linting
ronag Nov 22, 2019
c4fd502
fixup: don't use nextTick if not needed
ronag Nov 22, 2019
764e41a
fixup: state.length
ronag Nov 23, 2019
cf95bbd
fixup: state.length
ronag Nov 23, 2019
771a055
stream: error queued callbacks after active write has completed
ronag Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: state.length
  • Loading branch information
@ronag
ronag committed Dec 7, 2019
commit 764e41a8a506b9783d423582068de215d78bf37d
1 change: 1 addition & 0 deletions lib/_stream_writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,7 @@ function errorBuffer(state, err, sync) {
entry.callback(err);
}
}
state.length = 0;
state.bufferedRequest = null;
state.lastBufferedRequest = null;
state.bufferedRequestCount = 0;
Comment thread
ronag marked this conversation as resolved.
Outdated
Expand Down