Skip to content

src: clean up node_file.h #30530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

src: clean up node_file.h #30530

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6fbbdf
src: clean up node_file.h
addaleax Nov 18, 2019
623a982
fixup! src: clean up node_file.h
addaleax Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: clean up node_file.h
  • Loading branch information
@addaleax
addaleax committed Nov 19, 2019
commit 623a982fe695284889c1fd4ff820be7fb5e6772e
4 changes: 2 additions & 2 deletions src/node_file.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class FSReqBase : public ReqWrap<uv_fs_t> {
v8::Local<v8::Object> req,
AsyncWrap::ProviderType type,
bool use_bigint);
~FSReqBase();
~FSReqBase() override;

inline void Init(const char* syscall,
const char* data,
Expand Down Expand Up @@ -177,7 +177,7 @@ class FileHandle;
class FileHandleReadWrap final : public ReqWrap<uv_fs_t> {
public:
FileHandleReadWrap(FileHandle* handle, v8::Local<v8::Object> obj);
~FileHandleReadWrap();
~FileHandleReadWrap() override;

static inline FileHandleReadWrap* from_req(uv_fs_t* req) {
return static_cast<FileHandleReadWrap*>(ReqWrap::from_req(req));
Expand Down