Skip to content

tools: fix build at non-English windows #30492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pd4d10 wants to merge 1 commit into from
Closed

tools: fix build at non-English windows #30492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: fix build at non-English windows 
Fixes: #25885
  • Loading branch information
@pd4d10
pd4d10 committed Nov 17, 2019
commit e1478336400ea97bcfc67111e5d3855ddd94a47d
7 changes: 7 additions & 0 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,13 @@
],
},
'includes': ['toolchain.gypi', 'features.gypi'],
'target_defaults': {
'msvs_settings': {
'VCCLCompilerTool': {
'AdditionalOptions': ['/utf-8']
}
},
},
'targets': [
{
'target_name': 'run_torque',
Expand Down