Skip to content

src: mark ArrayBuffers with free callbacks as untransferable #30475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

src: mark ArrayBuffers with free callbacks as untransferable #30475

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44da3b3
src: mark ArrayBuffers with free callbacks as untransferable
addaleax Nov 13, 2019
47ff8a9
fixup! src: mark ArrayBuffers with free callbacks as untransferable
addaleax Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: mark ArrayBuffers with free callbacks as untransferable
  • Loading branch information
@addaleax
addaleax committed Nov 18, 2019
commit 47ff8a9414ec64970b49d6fe5e8d685db68f3efd
2 changes: 1 addition & 1 deletion test/addons/worker-buffer-callback/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const { buffer } = require(`./build/${common.buildType}/binding`);
// Test that buffers allocated with a free callback through our APIs are not
// transfered.

const { port1, port2 } = new MessageChannel();
const { port1 } = new MessageChannel();
const origByteLength = buffer.byteLength;
port1.postMessage(buffer, [buffer.buffer]);

Expand Down