Skip to content

tty: truecolor check moved before 256 check #30474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
duncanhealy wants to merge 4 commits into from
Closed

tty: truecolor check moved before 256 check #30474

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f3139c
tty: improve color check order highest spec first
duncanhealy Nov 13, 2019
4cd885f
tty: add test for TERM and COLORTERM set
duncanhealy Nov 13, 2019
7dde89e
tty: move COLORTERM check outside TERM closure
duncanhealy Nov 13, 2019
7df205f
tty: remove extra if check for COLORTERM
duncanhealy Nov 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tty: remove extra if check for COLORTERM
  • Loading branch information
@duncanhealy
duncanhealy committed Nov 17, 2019
commit 7df205f97d3978103d134759965d96d93e80feef
5 changes: 2 additions & 3 deletions lib/internal/tty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,8 @@ function getColorDepth(env = process.env) {
return COLORS_256;
}

if (env.COLORTERM) {
if (env.COLORTERM === 'truecolor' || env.COLORTERM === '24bit')
return COLORS_16m;
if (env.COLORTERM === 'truecolor' || env.COLORTERM === '24bit') {
return COLORS_16m;
}

if (env.TERM) {
Expand Down