Skip to content

benchmark: use let instead of var in assert #30451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dnlup wants to merge 1 commit into from
Closed

benchmark: use let instead of var in assert #30451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
benchmark: use let instead of var in assert 
Use let instead of var in benchmark/assert/deepequal-map.js.
  • Loading branch information
@dnlup
dnlup committed Nov 12, 2019
commit 6aead5cae06f2577f85a3ab78cb685028aa274ee
4 changes: 2 additions & 2 deletions benchmark/assert/deepequal-map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ function benchmark(method, n, values, values2) {
const deepCopy = JSON.parse(JSON.stringify(values2 ? values2 : values));
const expected = new Map(deepCopy);
bench.start();
for (var i = 0; i < n; ++i) {
for (let i = 0; i < n; ++i) {
method(actual, expected);
}
bench.end(n);
}

function main({ n, len, method, strict }) {
const array = Array(len).fill(1);
var values, values2;
let values, values2;

switch (method) {
case '':
Expand Down