Skip to content

net: improve performance by destructuring primordials #30447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 4 commits into from
+22 −17
Closed

net: improve performance by destructuring primordials #30447

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c9f52a
net: improve performance by destructuring primordials
Nov 12, 2019
45835ad
net: Remove unnecessary eslint-disable comment
Nov 14, 2019
dcca56d
Rename destructured object methods from primordials for clarity
Nov 15, 2019
2ea8780
Rename destructured object methods for consistency
Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
net: Remove unnecessary eslint-disable comment
  • Loading branch information
Guilherme Goncalves committed Nov 14, 2019
commit 45835ad86de88b34f1948fe780faa3a8e9dadf42
2 changes: 1 addition & 1 deletion lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ defineProperty(Socket.prototype, 'readyState', {


defineProperty(Socket.prototype, 'bufferSize', {
get: function() { // eslint-disable-line getter-return
get: function() {
Comment thread
lundibundi marked this conversation as resolved.
if (this._handle) {
return this[kLastWriteQueueSize] + this.writableLength;
}
Expand Down