Skip to content

doc: test-vm-function-declaration test add let declaration of function #30446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
duncanhealy wants to merge 2 commits into from
Closed

doc: test-vm-function-declaration test add let declaration of function #30446

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c248f68
doc: test-vm-function-declaration test add let declaration of function
duncanhealy Nov 12, 2019
b05c0e6
test: add function declaration tests for fat arrow
duncanhealy Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: test-vm-function-declaration test add let declaration of function
  • Loading branch information
@duncanhealy
duncanhealy committed Nov 12, 2019
commit c248f68288894f152e7e6dc74a8a66375c4986bc
6 changes: 4 additions & 2 deletions test/parallel/test-vm-function-declaration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,19 @@ const o = vm.createContext({ console });

// Function declaration and expression should both be copied to the
// sandboxed context.
let code = 'var a = function() {};\n';
let code = 'let a = function() {};\n';
Comment thread
addaleax marked this conversation as resolved.
code += 'function b(){}\n';
code += 'var c = function() {};\n';

// Grab the global b function as the completion value, to ensure that
// we are getting the global function, and not some other thing
code += '(function(){return this})().b;\n';

const res = vm.runInContext(code, o, 'test');

assert.strictEqual(typeof res, 'function');
assert.strictEqual(res.name, 'b');
assert.strictEqual(typeof o.a, 'function');
Comment thread
BridgeAR marked this conversation as resolved.
Outdated
assert.strictEqual(typeof o.b, 'function');
assert.strictEqual(typeof o.c, 'function');

assert.strictEqual(res, o.b);