Skip to content

test: change object assign to spread object in test/parallel/test-npm-install.js #30422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
putxe wants to merge 3 commits into from
Closed

test: change object assign to spread object in test/parallel/test-npm-install.js #30422

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
243acc3
test: change object assign to spread object in test-npm-install.js
putxe Nov 12, 2019
5ec47ba
test: clean spread object in test-npm-install.js
putxe Nov 12, 2019
c7efb41
test: resolve eslint errors in test-npm-install.js
putxe Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: resolve eslint errors in test-npm-install.js
  • Loading branch information
@putxe
putxe committed Nov 12, 2019
commit c7efb41b79d073c9ff08f8bc77b7c554dec7b7ef
10 changes: 5 additions & 5 deletions test/parallel/test-npm-install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ const pkgPath = path.join(installDir, 'package.json');

fs.writeFileSync(pkgPath, pkgContent);

const env = {...process.env,
PATH: path.dirname(process.execPath),
NPM_CONFIG_PREFIX: path.join(npmSandbox, 'npm-prefix'),
NPM_CONFIG_TMP: path.join(npmSandbox, 'npm-tmp'),
HOME: homeDir,
const env = { ...process.env,
Copy link
Copy Markdown
Member

@trivikr trivikr Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can be made more readable as follows:

const env = {
  ...process.env,
  PATH: path.dirname(process.execPath),
  NPM_CONFIG_PREFIX: path.join(npmSandbox, 'npm-prefix'),
  NPM_CONFIG_TMP: path.join(npmSandbox, 'npm-tmp'),
  HOME: homeDir
};

PATH: path.dirname(process.execPath),
NPM_CONFIG_PREFIX: path.join(npmSandbox, 'npm-prefix'),
NPM_CONFIG_TMP: path.join(npmSandbox, 'npm-tmp'),
HOME: homeDir,
};

exec(`${process.execPath} ${npmPath} install`, {
Expand Down