Skip to content

src: fix function and variable names in comments #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thefourtheye wants to merge 2 commits into from
Closed

src: fix function and variable names in comments #3039

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
952ff9c
src: fix function and variable names in comments
thefourtheye Sep 24, 2015
132a687
Improve text
thefourtheye Sep 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: fix function and variable names in comments 
The `src/node.js` file is actually loaded and executed by
`node::LoadEnvironment` function.

The variable which has the contents is, `native_node`.
  • Loading branch information
@thefourtheye
thefourtheye committed Sep 24, 2015
commit 952ff9cfa5b38c72aa4faec77e442a6f909fff78
2 changes: 1 addition & 1 deletion src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2955,7 +2955,7 @@ void LoadEnvironment(Environment* env) {
env->isolate()->AddMessageListener(OnMessage);

// Compile, execute the src/node.js file. (Which was included as static C
// string in node_natives.h. 'natve_node' is the string containing that
// string in node_natives.h. 'native_node' is the string containing that
// source code.)

// The node.js file returns a function 'f'
Expand Down
7 changes: 4 additions & 3 deletions src/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// Hello, and welcome to hacking node.js!
//
// This file is invoked by node::Load in src/node.cc, and responsible for
// bootstrapping the node.js core. Special caution is given to the performance
// of the startup process, so many dependencies are invoked lazily.
// This file is invoked by node::LoadEnvironment in src/node.cc, and
Copy link
Copy Markdown
Contributor

@mscdex mscdex Sep 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably read "and is" instead of just "and."

Copy link
Copy Markdown
Contributor Author

@thefourtheye thefourtheye Sep 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscdex Sure, I updated it.

// responsible for bootstrapping the node.js core. Special caution is given to
// the performance of the startup process, so many dependencies are invoked
// lazily.

'use strict';

Expand Down