Skip to content

src: introduce custom smart pointers for BaseObjects #30374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 5 commits into from
Closed

src: introduce custom smart pointers for BaseObjects #30374

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ff2122
src: introduce custom smart pointers for `BaseObject`s
addaleax Sep 28, 2019
c371a37
http2: use custom BaseObject smart pointers
addaleax Sep 28, 2019
697e719
src: use BaseObjectPtr for keeping channel alive in dns bindings
addaleax Nov 12, 2019
82f06be
src: remove keep alive option from SetImmediate()
addaleax Nov 12, 2019
360b843
src: remove HandleWrap instances from list once closed
addaleax Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: remove HandleWrap instances from list once closed 
This allows keeping `BaseObjectPtr`s to `HandleWrap` instances.
Previously, the pointer kept the `HandleWrap` object alive, leaving
the Environment cleanup code that waits for the handle list to drain
in a busy loop, because only the `HandleWrap` destructor removed
the item from the list.

Refs: nodejs/quic#165
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
  • Loading branch information
@addaleax
addaleax committed Nov 12, 2019
commit 360b843d040c568a03264aa5548a1627731fca93
1 change: 1 addition & 0 deletions src/handle_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ void HandleWrap::OnClose(uv_handle_t* handle) {
wrap->state_ = kClosed;

wrap->OnClose();
wrap->handle_wrap_queue_.Remove();

if (!wrap->persistent().IsEmpty() &&
wrap->object()->Has(env->context(), env->handle_onclose_symbol())
Expand Down