Skip to content

util: fix .format() not always calling toString when it should be #30343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

util: fix .format() not always calling toString when it should be #30343

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cde7fde
util: fix .format() not always calling toString when it should be
BridgeAR Nov 9, 2019
2f48041
fixup
BridgeAR Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@BridgeAR
BridgeAR committed Nov 26, 2019
commit 2f480411a6717253e24fc201fd7d266e6ede2452
4 changes: 2 additions & 2 deletions lib/internal/util/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,7 +1578,7 @@ function hasBuiltInToString(value) {
}

// The object has a own `toString` property. Thus it's not not a built-in one.
if (hasOwnProperty(value, 'toString')) {
if (ObjectPrototypeHasOwnProperty(value, 'toString')) {
return false;
}

Expand All @@ -1587,7 +1587,7 @@ function hasBuiltInToString(value) {
let pointer = value;
do {
pointer = ObjectGetPrototypeOf(pointer);
} while (!hasOwnProperty(pointer, 'toString'));
} while (!ObjectPrototypeHasOwnProperty(pointer, 'toString'));

// Check closer if the object is a built-in.
const descriptor = ObjectGetOwnPropertyDescriptor(pointer, 'constructor');
Expand Down