Skip to content

test: cover 'close' method (in Dir class) with tests #30310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
artmaks wants to merge 2 commits into from
Closed

test: cover 'close' method (in Dir class) with tests #30310

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52499de
test: cover 'close' method (in Dir class) with tests
artmaks Nov 6, 2019
b3e84a6
test: fix a typo
artmaks Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: cover 'close' method (in Dir class) with tests 
Add 2 tests for full covering of method 'close' in class Dir
1. If pass smth that not string as a callback - throw an exception
2. If do .close() on already closed directory - throw an exception
  • Loading branch information
@artmaks
artmaks committed Nov 6, 2019
commit 52499de3cda8d75b58a1b8a56f5d1a3d7adbe983
22 changes: 22 additions & 0 deletions test/parallel/test-fs-opendir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ const dirclosedError = {
code: 'ERR_DIR_CLOSED'
};

const invalidCallbackObj = {
code: 'ERR_INVALID_CALLBACK',
name: 'TypeError'
};

// Check the opendir Sync version
{
const dir = fs.opendirSync(testDir);
Expand Down Expand Up @@ -205,3 +210,20 @@ for (const bufferSize of ['', '1', null]) {
assertDirent(dir.readSync());
dir.close();
}

// Check that when passing a string instead of function - throw an exception
async function doAsyncIterInvalidCallbackTest() {
const dir = await fs.promises.opendir(testDir);
``
Comment thread
trivikr marked this conversation as resolved.
Outdated
assert.throws(() => dir.close('not function'), invalidCallbackObj);
}
doAsyncIterInvalidCallbackTest().then(common.mustCall());

// Check if directory already closed - throw an exception
async function doAsyncIterDirClosedTest() {
const dir = await fs.promises.opendir(testDir);
await dir.close();

assert.throws(() => dir.close(), dirclosedError);
}
doAsyncIterDirClosedTest().then(common.mustCall());