Skip to content

dgram: remove listeners on bind error #30210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

dgram: remove listeners on bind error #30210

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e17fcc8
dgram: reset bind state before emitting error
addaleax Nov 1, 2019
2d8aa64
dgram: remove listeners on bind error
addaleax Nov 1, 2019
f603ff4
fixup! dgram: remove listeners on bind error
addaleax Nov 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! dgram: remove listeners on bind error
  • Loading branch information
@addaleax
addaleax committed Nov 2, 2019
commit f603ff405d7253580436b64b4c0ad2bb2a787e12
3 changes: 1 addition & 2 deletions test/parallel/test-dgram-bind-error-repeat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ reservePortSocket.bind(() => {
let errors = 0;
newSocket.on('error', common.mustCall(() => {
if (++errors < 20) {
const cb = errors === 20 ? common.mustCall() : common.mustNotCall();
newSocket.bind(port, cb);
newSocket.bind(port, common.mustNotCall());
} else {
newSocket.close();
reservePortSocket.close();
Expand Down