Skip to content

http: fix incorrect headersTimeout measurement #30184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OrKoN wants to merge 5 commits into from
Closed

http: fix incorrect headersTimeout measurement #30184

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7281ca
http: fix incorrect headersTimeout measurement
OrKoN Oct 30, 2019
8cfd1b8
test: fix flaky test-http-highwatermark
OrKoN Oct 31, 2019
aa83993
http: add nowDate() to async scope
OrKoN Nov 1, 2019
845d4bb
http: use nullptr to fix win build
OrKoN Jan 5, 2020
01c2228
http: revert flaky test fix
OrKoN Jan 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix flaky test-http-highwatermark
  • Loading branch information
@OrKoN
OrKoN committed Mar 17, 2020
commit 8cfd1b8d39c422b91f6ba1c95a200c955a220ed8
2 changes: 1 addition & 1 deletion test/parallel/test-http-highwatermark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ let requestReceived = 0;
const server = http.createServer(function(req, res) {
const id = ++requestReceived;
const enoughToDrain = req.connection.writableHighWaterMark;
const body = 'x'.repeat(enoughToDrain * 100);
const body = 'x'.repeat(enoughToDrain * 200);
Copy link
Copy Markdown
Contributor Author

@OrKoN OrKoN Oct 31, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the single unrelated test that is failing. I saw in its history that it was fixed as a flaky in the past. It seems to fails again and I don't think that it's related to my changes.


if (id === 1) {
// Case of needParse = false
Expand Down