Skip to content

fs: Add noop stub for FSWatcher.prototype.start #30160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lholmquist wants to merge 4 commits into from
Closed

fs: Add noop stub for FSWatcher.prototype.start #30160

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
750d945
fs: Add noop stub for FSWatcher.prototype.start
lholmquist Oct 29, 2019
9b836a8
squash: add a comment for future maintainers
lholmquist Oct 29, 2019
da2c3b3
squash: Update lib/internal/fs/watchers.js
lholmquist Oct 29, 2019
7df938b
squash: Update lib/internal/fs/watchers.js
lholmquist Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: Update lib/internal/fs/watchers.js 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@lholmquist @Trott
lholmquist and Trott authored Oct 29, 2019
commit da2c3b3e16c81e17fa1dfa2db99f0f215189d24c
2 changes: 1 addition & 1 deletion lib/internal/fs/watchers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ FSWatcher.prototype[kFSWatchStart] = function(filename,
}
};

// To maximize backword-compatiblity for the end user
// To maximize backward-compatiblity for the end user,
// a no-op stub method has been added instead of
// totally removing FSWatcher.prototpye.start.
// This should not be documented
Comment thread
lholmquist marked this conversation as resolved.
Outdated
Expand Down