Skip to content

build: find Python syntax errors in dependencies #30143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cclauss wants to merge 2 commits into from
Closed

build: find Python syntax errors in dependencies #30143

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8444de8
build: find Python syntax errors in dependencies
cclauss Oct 27, 2019
c69a472
fixup: allow_failures until dependencies pass
cclauss Oct 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: find Python syntax errors in dependencies 
As discussed in #30129 (comment), when we vendor in code, we own the Syntax Errors in that code.  This PR adds The `.flake8` config file at the root of this repo puts blinders on the linting of our dependencies so this test disables that file before linting.
  • Loading branch information
@cclauss
cclauss committed Oct 31, 2019
commit 8444de800deebf2199f51f93237acdf087e35454
10 changes: 10 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,13 @@ jobs:
- if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST};
fi

- name: "Find syntax errors in our Python dependencies"
language: python
python: 3.8
install:
- mv .flake8 disabled.flake8 # take the blinders off of flake8
- python3.8 -m pip install --upgrade pip
- python3.8 -m pip install flake8
script:
- flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics