Skip to content

doc: update examples in writing-tests.md #30126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GaryGSC wants to merge 3 commits into from
Closed

doc: update examples in writing-tests.md #30126

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2bb486
doc: use arrow functions in writing-tests.md
GaryGSC Oct 25, 2019
f57926f
doc: sync example in writing-tests.md
GaryGSC Oct 25, 2019
e2e095a
doc: match functionality in writing-tests.md example
GaryGSC Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions doc/guides/writing-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,18 +163,18 @@ const http = require('http');

let request = 0;
let response = 0;
process.on('exit', function() {
process.on('exit', () => {
assert.equal(request, 1, 'http server "request" callback was not called');
assert.equal(response, 1, 'http request "response" callback was not called');
});

const server = http.createServer((req, res) => {
request++;
res.end();
}).listen(0, function() {
}).listen(0, () => {
const options = {
agent: null,
port: this.address().port
port: server.address().port
};
http.get(options, (res) => {
response++;
Expand All @@ -193,16 +193,16 @@ const http = require('http');

const server = http.createServer(common.mustCall((req, res) => {
res.end();
})).listen(0, function() {
})).listen(0, common.mustCall(() => {
Comment thread
trivikr marked this conversation as resolved.
const options = {
agent: null,
port: this.address().port
port: server.address().port
};
http.get(options, common.mustCall((res) => {
res.resume();
server.close();
}));
});
}));

```

Expand All @@ -216,7 +216,7 @@ shutting down an HTTP server after a specific number of requests).
```javascript
const Countdown = require('../common/countdown');

const countdown = new Countdown(2, function() {
const countdown = new Countdown(2, () => {
console.log('.');
});

Expand Down