Skip to content

tools: doc: improve async workflow of generate.js #30106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tpoisseau wants to merge 2 commits into from
Closed

tools: doc: improve async workflow of generate.js #30106

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75f4b78
tools: doc: improve async workflow of generate.js
tpoisseau Oct 24, 2019
c1cbd68
Apply suggestions from code review
tpoisseau Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@tpoisseau @targos
tpoisseau and targos authored Oct 24, 2019
commit c1cbd68237af859e10600c07d2a4aaefbd1e1cc2
4 changes: 2 additions & 2 deletions tools/doc/generate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ async function main() {

main()
.then((tasks) => {
// Filter tasks rejected
// Filter rejected tasks
const errors = tasks.filter(({ status }) => status === 'rejected')
.map(({ reason }) => reason);

Expand All @@ -108,7 +108,7 @@ main()
return process.exit(1);
Copy link
Copy Markdown
Member

@devsnek devsnek Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically you don't need a return here :P

Copy link
Copy Markdown
Contributor Author

@tpoisseau tpoisseau Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but I think it's more clear and concistent whith early return pattern (I don't know the real name)

}

// Else with code 1
// Else with code 0
process.exit(0);
})
.catch((error) => {
Expand Down