Skip to content

Don't use -latomic on macOS #30099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryandesign wants to merge 1 commit into from
Closed

Don't use -latomic on macOS #30099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't use -latomic on macOS 
Fixes build when using open-source clang. (Builds using Apple clang from Xcode
7 and later were already working, due to the fact that node's build system
misidentifies their llvm_version as "0.0" and thus the flag wasn't being added.)

Closes #30093
  • Loading branch information
@ryandesign
ryandesign authored Oct 23, 2019
commit dcfe2b2dc9d04e2a570ed0e4a822d42034ee6076
2 changes: 1 addition & 1 deletion node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@
'-Wl,-bnoerrmsg',
],
}],
['OS in ("linux", "mac") and llvm_version != "0.0"', {
['OS == "linux" and llvm_version != "0.0"', {
'libraries': ['-latomic'],
}],
],
Expand Down