Skip to content

v13.0.1 proposal #30081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 33 commits into from
Oct 23, 2019
Merged

v13.0.1 proposal #30081

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
828e171
doc: add server header into the discarded list of http message.headers
Huachao Oct 14, 2019
d80ece6
doc: re-enable passing remark-lint rule
nschonni Oct 14, 2019
dc83ff9
doc: remove unused Markdown reference links
nschonni Oct 14, 2019
b1b8663
test: add cb error test for fs.close()
teorossi82 Oct 14, 2019
3eae670
src: refine maps parsing for large pages
Oct 9, 2019
62b4ca6
doc: clarify readable.unshift null/EOF
ronag Oct 16, 2019
cfd45eb
module: refactor modules bootstrap
bfarias-godaddy Sep 30, 2019
9729c5d
esm: modify resolution order for specifier flag
MylesBorins Oct 14, 2019
2dc4da0
build: build benchmark addons like test addons
richardlau Oct 16, 2019
b92afcd
build: fix version checks in configure.py
targos Oct 14, 2019
ff4f299
doc: fix tls version typo
akitsu-sanae Oct 15, 2019
c096f25
test: remove common.skipIfInspectorEnabled()
Trott Oct 16, 2019
ccf5883
build: use python3 to build and test on Travis
cclauss Sep 5, 2019
b019ccd
src: initialize openssl only once
sam-github Oct 16, 2019
0299767
doc: update collaborator email address
JungMinu Oct 17, 2019
e110d81
test: fix test runner for Python 3 on Windows
targos Oct 18, 2019
e04d058
build: default Windows build to Visual Studio 2019
targos Oct 18, 2019
a25d2fc
build: make configure --without-snapshot a no-op
targos Oct 18, 2019
9d332ab
deps: upgrade to libuv 1.33.1
cjihrig Oct 19, 2019
9721440
src: remove unused iomanip include
danbev Oct 17, 2019
0c88dc1
src: fewer uses of NODE_USE_V8_PLATFORM
codebytere Oct 18, 2019
f155dfe
test: expand Worker test for non-shared ArrayBuffer
addaleax Oct 20, 2019
46aa481
stream: remove dead code
lpinca Oct 20, 2019
f3712df
stream: simplify uint8ArrayToBuffer helper
lpinca Oct 20, 2019
35bffcd
doc: join parts of disrupt section in cli.md
vsemozhetbyt Oct 19, 2019
13f3d6c
build: log the found compiler version if too old
richardlau Oct 18, 2019
8fcc039
src: expose ListNode<T>::prev_ on postmortem metadata
legendecas Oct 18, 2019
ed80c23
src: make implementing CancelPendingDelayedTasks for platform optional
addaleax Oct 19, 2019
19a983c
build: make linter failures fail `test-doc` target
richardlau Oct 17, 2019
d561321
src: remove unnecessary std::endl usage
danbev Oct 17, 2019
89b9115
doc: --enable-source-maps and prepareStackTrace are incompatible
Oct 21, 2019
2f36976
deps: npm: patch support for 13.x
ljharb Oct 22, 2019
bdc09c6
2019-10-23, Version 13.0.1 (Current)
MylesBorins Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: fewer uses of NODE_USE_V8_PLATFORM 
PR-URL: #30029
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
@codebytere @MylesBorins
codebytere authored and MylesBorins committed Oct 23, 2019
commit 0c88dc19327d8daaebf46bbed9a9ce80b40bf2ae
2 changes: 1 addition & 1 deletion src/env.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ class Environment : public MemoryRetainer {
void CreateProperties();
// Should be called before InitializeInspector()
void InitializeDiagnostics();
#if HAVE_INSPECTOR && NODE_USE_V8_PLATFORM
#if HAVE_INSPECTOR
// If the environment is created for a worker, pass parent_handle and
// the ownership if transferred into the Environment.
int InitializeInspector(inspector::ParentInspectorHandle* parent_handle);
Expand Down
2 changes: 1 addition & 1 deletion src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ MaybeLocal<Value> ExecuteBootstrapper(Environment* env,
return scope.EscapeMaybe(result);
}

#if HAVE_INSPECTOR && NODE_USE_V8_PLATFORM
#if HAVE_INSPECTOR
int Environment::InitializeInspector(
inspector::ParentInspectorHandle* parent_handle) {
std::string inspector_path;
Expand Down
2 changes: 1 addition & 1 deletion src/node_main_instance.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ std::unique_ptr<Environment> NodeMainInstance::CreateMainEnvironment(

// TODO(joyeecheung): when we snapshot the bootstrapped context,
// the inspector and diagnostics setup should after after deserialization.
#if HAVE_INSPECTOR && NODE_USE_V8_PLATFORM
#if HAVE_INSPECTOR
*exit_code = env->InitializeInspector(nullptr);
#endif
if (*exit_code != 0) {
Expand Down
12 changes: 6 additions & 6 deletions src/node_worker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "util-inl.h"
#include "async_wrap-inl.h"

#if NODE_USE_V8_PLATFORM && HAVE_INSPECTOR
#if HAVE_INSPECTOR
#include "inspector/worker_inspector.h" // ParentInspectorHandle
#endif

Expand Down Expand Up @@ -39,7 +39,7 @@ namespace worker {

namespace {

#if NODE_USE_V8_PLATFORM && HAVE_INSPECTOR
#if HAVE_INSPECTOR
void WaitForWorkerInspectorToStop(Environment* child) {
child->inspector_agent()->WaitForDisconnect();
child->inspector_agent()->Stop();
Expand Down Expand Up @@ -82,7 +82,7 @@ Worker::Worker(Environment* env,
Number::New(env->isolate(), static_cast<double>(thread_id_)))
.Check();

#if NODE_USE_V8_PLATFORM && HAVE_INSPECTOR
#if HAVE_INSPECTOR
inspector_parent_handle_ =
env->inspector_agent()->GetParentHandle(thread_id_, url);
#endif
Expand Down Expand Up @@ -193,7 +193,7 @@ void Worker::Run() {
Locker locker(isolate_);
Isolate::Scope isolate_scope(isolate_);
SealHandleScope outer_seal(isolate_);
#if NODE_USE_V8_PLATFORM && HAVE_INSPECTOR
#if HAVE_INSPECTOR
bool inspector_started = false;
#endif

Expand Down Expand Up @@ -225,7 +225,7 @@ void Worker::Run() {
env_->stop_sub_worker_contexts();
env_->RunCleanup();
RunAtExit(env_.get());
#if NODE_USE_V8_PLATFORM && HAVE_INSPECTOR
#if HAVE_INSPECTOR
if (inspector_started)
WaitForWorkerInspectorToStop(env_.get());
#endif
Expand Down Expand Up @@ -270,7 +270,7 @@ void Worker::Run() {
if (is_stopped()) return;
{
env_->InitializeDiagnostics();
#if NODE_USE_V8_PLATFORM && HAVE_INSPECTOR
#if HAVE_INSPECTOR
env_->InitializeInspector(inspector_parent_handle_.release());
inspector_started = true;
#endif
Expand Down
2 changes: 1 addition & 1 deletion src/node_worker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class Worker : public AsyncWrap {
bool start_profiler_idle_notifier_;
uv_thread_t tid_;

#if NODE_USE_V8_PLATFORM && HAVE_INSPECTOR
#if HAVE_INSPECTOR
std::unique_ptr<inspector::ParentInspectorHandle> inspector_parent_handle_;
#endif

Expand Down