Skip to content

src: fix crash with SyntheticModule#setExports #30062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 2 commits into from
Closed

src: fix crash with SyntheticModule#setExports #30062

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f13686b
deps: V8: backport 777fa98
targos Oct 22, 2019
48c74ef
src: fix crash with SyntheticModule#setExport
targos Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: fix crash with SyntheticModule#setExport 
Use the new non-deprecated V8 API for that.
  • Loading branch information
@targos
targos committed Oct 25, 2019
commit 48c74ef36b67a0a6733dc9a84c56865da37d92d1
2 changes: 1 addition & 1 deletion src/module_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,7 +1500,7 @@ void ModuleWrap::SetSyntheticExport(
Local<Value> export_value = args[1];

Local<Module> module = obj->module_.Get(isolate);
module->SetSyntheticModuleExport(export_name, export_value);
USE(module->SetSyntheticModuleExport(isolate, export_name, export_value));
}

void ModuleWrap::Initialize(Local<Object> target,
Expand Down
3 changes: 0 additions & 3 deletions test/parallel/test-vm-module-synthetic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ const assert = require('assert');
});
}

// https://bugs.chromium.org/p/v8/issues/detail?id=9828
/*
{
const s = new SyntheticModule([], () => {});
await s.link(() => {});
Expand All @@ -47,7 +45,6 @@ const assert = require('assert');
name: 'ReferenceError',
});
}
*/

{
const s = new SyntheticModule([], () => {});
Expand Down