Skip to content

build,test: add .ci.yml for containered tests (WIP proposal) #30057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rvagg wants to merge 6 commits into from
Closed

build,test: add .ci.yml for containered tests (WIP proposal) #30057

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
091a1f5
build,test: add .ci.yml for containered tests
rvagg Oct 20, 2019
56d4f4b
fixup! build,test: add .ci.yml for containered tests
rvagg Oct 27, 2019
c4d0ae1
fixup! build,test: add .ci.yml for containered tests
rvagg Oct 27, 2019
74cb7d0
fixup! build,test: add .ci.yml for containered tests
rvagg Oct 27, 2019
b52aa4b
fixup! build,test: add .ci.yml for containered tests
rvagg Oct 27, 2019
6c28e1e
TEMP: remove test-wasi.js, failing on containers
rvagg Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! build,test: add .ci.yml for containered tests
  • Loading branch information
@rvagg
rvagg committed Jun 30, 2020
commit b52aa4b8a0d65a71a29260ee34adcf2031b31313
5 changes: 4 additions & 1 deletion .ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ tests:
label: Lint JS, C++, Python, Markdown & Docs
image: node-linter
execute: |
make lint-ci || {
make lint-py-build PYTHON=python3
make lint-py PYTHON=python3
make lint-py-build PYTHON=python2
make lint-ci PYTHON=python2 || {
Copy link
Copy Markdown
Contributor

@cclauss cclauss Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't PYTHON be defined before running make instead of after?

Copy link
Copy Markdown
Member

@richardlau richardlau Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do either.

PYTHON=python2 make lint-ci

Sets the PYTHON environment variable in the shell and runs make, which turns environment variables into make variables: https://www.gnu.org/software/make/manual/html_node/Environment.html#Environment

make lint-ci PYTHON=python2

Overrides the make variable from the command line: https://www.gnu.org/software/make/manual/html_node/Overriding.html

cat test-eslint.tap | grep -v '^ok\|^TAP version 13\|^1\.\.' | sed '/^\s*$/d' &&
exit 1; }

Expand Down