Skip to content

cli: add --trace-uncaught flag #30025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

cli: add --trace-uncaught flag #30025

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce0bc30
cli: add --trace-uncaught flag
addaleax Oct 18, 2019
6a577ce
fixup! cli: add --trace-uncaught flag
addaleax Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! cli: add --trace-uncaught flag
  • Loading branch information
@addaleax
addaleax committed Oct 18, 2019
commit 6a577ce192bfe83d903eb0a43361ab23bdab0e83
3 changes: 0 additions & 3 deletions src/env.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,6 @@ Environment::Environment(IsolateData* isolate_data,
async_hooks_.no_force_checks();
}

if (options_->trace_uncaught)
isolate()->SetCaptureStackTraceForUncaughtExceptions(true);

// TODO(joyeecheung): deserialize when the snapshot covers the environment
// properties.
CreateProperties();
Expand Down
2 changes: 2 additions & 0 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,8 @@ int Environment::InitializeInspector(
void Environment::InitializeDiagnostics() {
isolate_->GetHeapProfiler()->AddBuildEmbedderGraphCallback(
Environment::BuildEmbedderGraph, this);
if (options_->trace_uncaught)
isolate_->SetCaptureStackTraceForUncaughtExceptions(true);

#if defined HAVE_DTRACE || defined HAVE_ETW
InitDTrace(this);
Expand Down