Skip to content

fs: make FSStatWatcher.start private #29971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lholmquist wants to merge 4 commits into from
Closed

fs: make FSStatWatcher.start private #29971

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f4c116
fs: make FSStatWatcher.start private
lholmquist Oct 14, 2019
0aef197
squash: adding back in the start method, but as a stub
lholmquist Oct 28, 2019
1ec46c6
squash: add a comment for future maintainers
lholmquist Oct 29, 2019
7e03961
squash: slight spelling and grammer update
lholmquist Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: add a comment for future maintainers
  • Loading branch information
@lholmquist
lholmquist committed Nov 6, 2019
commit 1ec46c65bf472cb234cc69423ed18fa111fa0625
4 changes: 4 additions & 0 deletions lib/internal/fs/watchers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ StatWatcher.prototype[kFSStatWatcherStart] = function(filename,
}
};

// To maximize backword-compatiblity for the end user
// a no-op stub method has been added instead of
// totally removing StatWatcher.prototpye.start.
// This should not be documented
StatWatcher.prototype.start = () => {};

// FIXME(joyeecheung): this method is not documented while there is
Expand Down