Skip to content

Modules bootstrap refactoring #29937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 14 commits into from
Closed

Modules bootstrap refactoring #29937

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4c8d820
module: refactor modules bootstrap
bfarias-godaddy Sep 30, 2019
76b4153
bootstrap complete before user code
guybedford Oct 11, 2019
eb97b1c
fixup for merge
guybedford Oct 11, 2019
31bb33f
avoid unnecessary test change
guybedford Oct 11, 2019
7c47066
remove unnecessary test change
guybedford Oct 11, 2019
0f6c8c0
ensure warning triggers immediately
guybedford Oct 11, 2019
2d4dfef
keep CJS runMain, move main to process
guybedford Oct 13, 2019
fe0c923
defaultOnly comment
guybedford Oct 13, 2019
c750488
move main functions into pre_execution
guybedford Oct 14, 2019
ad0f5c7
pr feedback
guybedford Oct 15, 2019
29d1d9c
async_hooks fix
guybedford Oct 15, 2019
91a3772
esm loader initialize as async
guybedford Oct 15, 2019
f638d29
fixup worker test
guybedford Oct 16, 2019
673257d
feedback
guybedford Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bootstrap complete before user code
  • Loading branch information
@guybedford
guybedford committed Oct 14, 2019
commit 76b41531c4d28846e167b59da08f2bc28dcb5084
5 changes: 3 additions & 2 deletions lib/internal/main/run_main_module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ const {
prepareMainThreadExecution(true);

const runMainAsync = require('internal/main/main');

markBootstrapComplete();

const asyncMain = runMainAsync(process.argv[1]);

// Sync runMain. Async case hands over control to the promise chain.
Expand All @@ -16,5 +19,3 @@ if (!asyncMain) {
const CJSModule = require('internal/modules/cjs/loader').Module;
CJSModule.runMain(process.argv[1]);
}

markBootstrapComplete();