Skip to content

http2: allow passing FileHandle to respondWithFD #29876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 5 commits into from
Closed

http2: allow passing FileHandle to respondWithFD #29876

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7d8a42
http2: allow passing FileHandle to respondWithFD
addaleax Oct 4, 2019
bad2b2d
fixup! http2: allow passing FileHandle to respondWithFD
addaleax Oct 7, 2019
e9d05d2
fixup! fixup! http2: allow passing FileHandle to respondWithFD
addaleax Oct 7, 2019
3c91a7e
fixup! http2: allow passing FileHandle to respondWithFD
addaleax Oct 7, 2019
cd4d52c
fixup! fixup! http2: allow passing FileHandle to respondWithFD
addaleax Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! http2: allow passing FileHandle to respondWithFD
  • Loading branch information
@addaleax
addaleax committed Oct 8, 2019
commit bad2b2de84587a419659f00eb3648a4c27185829
2 changes: 1 addition & 1 deletion doc/api/http2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,7 +1440,7 @@ server.on('stream', (stream) => {
added: v8.4.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/????
pr-url: https://github.com/nodejs/node/pull/29876
description: The `fd` option may now be a `FileHandle`.
- version: v10.0.0
pr-url: https://github.com/nodejs/node/pull/18936
Expand Down