Skip to content

doc: notes about forwarding stream options #29857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 3 commits into from
Closed

doc: notes about forwarding stream options #29857

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58c813f
doc: notes about forwarding stream options
ronag Oct 6, 2019
e919ab6
fixup: autoDestroy
ronag Oct 8, 2019
50ee054
Apply suggestions from code review
ronag Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: autoDestroy
  • Loading branch information
@ronag
ronag committed Oct 8, 2019
commit e919ab68cc9e5e76ba60f11282df94537a033893
2 changes: 1 addition & 1 deletion doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1648,7 +1648,7 @@ class MyWritable extends Writable {
constructor({ highWaterMark, ...options }) {
super({
highWaterMark,
Comment thread
lpinca marked this conversation as resolved.
autoDestroy: false,
autoDestroy: true,
emitClose: true
});
// ...
Expand Down