Skip to content

stream: don't deadlock duplexpair #29836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

stream: don't deadlock duplexpair #29836

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5458e34
test: test HTTP server response with Connection: close
awwright Sep 22, 2019
0faf029
stream: don't deadlock duplexpair
ronag Oct 3, 2019
b2600ca
fixup: simplify
ronag Oct 3, 2019
bd0220d
fixup: added docs
ronag Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: added docs
  • Loading branch information
@ronag
ronag committed Oct 4, 2019
commit bd0220d0074bc26bc33f4db0ca684618449b4cea
4 changes: 3 additions & 1 deletion doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2060,7 +2060,9 @@ when `_read()` is called again after it has stopped should it resume pushing
additional data onto the queue.

Once the `readable._read()` method has been called, it will not be called again
until the [`readable.push()`][stream-push] method is called.
until more data is pushed through the [`readable.push()`][stream-push] method.
Empty data such as empty buffers and strings will not cause `readable._read()`
to be called.

The `size` argument is advisory. For implementations where a "read" is a
single operation that returns data can use the `size` argument to determine how
Expand Down